diff options
| author |  Michael Smith <mikesmiffy128@gmail.com>
| 2025-12-27 03:05:05 +0000 |
|---|---|---|
| committer | Michael Smith <mikesmiffy128@gmail.com>
| 2026-02-16 19:11:24 +0000 |
| commit | 8d4b47298b6c9eeb9a3f79a5b80d894f80ed4a45 (patch) | |
| tree | 63a8ea6f645b997fd7943a58a002e66244fa49ac /src/portalcolours.c | |
| parent | e7943fb834cbcaec585ed68e67b5f17ceda504f7 (diff) | |
| download | sst-8d4b47298b6c9eeb9a3f79a5b80d894f80ed4a45.tar.gz sst-8d4b47298b6c9eeb9a3f79a5b80d894f80ed4a45.zip | |
Do away with memcpy/memset/memcmp
Now everything is either explicitly a rep thing, or explicitly some
other small run of reasonably efficient instructions. No library calls
or function call overhead of any kind. Code size remains nice and small.
Ban a few other bad libc functions while we're at it. More can be added
later if we decide that's a useful idea.
This will require some discipline and workarounds to cope with Clang's
tendency to shove mem* calls in places you don't want them even when you
tell it not to. Well, c'est la vie.
I'm a little nervous that the __builtin_memmove() usage in shuntvars()
could still one day emit actual library calls. It appears we're not
importing memmove() from anywhere at the moment, though. So I guess it's
good enough for now.
Also I had to get rid of alloca() in con_.c but that was kind of bad
anyway, so that's fine.
Diffstat (limited to 'src/portalcolours.c')
| -rw-r--r-- | src/portalcolours.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/portalcolours.c b/src/portalcolours.c index ff9ab46..41b3a07 100644 --- a/src/portalcolours.c +++ b/src/portalcolours.c @@ -14,8 +14,6 @@ * PERFORMANCE OF THIS SOFTWARE. */ -#include <string.h> - #include "con_.h" #include "engineapi.h" #include "errmsg.h" @@ -81,19 +79,19 @@ static UTIL_Portal_Color_func find_UTIL_Portal_Color(void *base) { E8, 01, B1, FF, 74, 1E, 83, E8, 01, 8B, 44, 24, 04, 88); // 5135 void *f = mem_offset(base, 0x1BF090); - if (!memcmp(f, x, sizeof(x))) return (UTIL_Portal_Color_func)f; + if (!mem_cmp(f, x, sizeof(x))) return (UTIL_Portal_Color_func)f; // 4104 f = mem_offset(base, 0x1ADC30); - if (!memcmp(f, x, sizeof(x))) return (UTIL_Portal_Color_func)f; + if (!mem_cmp(f, x, sizeof(x))) return (UTIL_Portal_Color_func)f; // 3420 f = mem_offset(base, 0x1AA810); - if (!memcmp(f, x, sizeof(x))) return (UTIL_Portal_Color_func)f; + if (!mem_cmp(f, x, sizeof(x))) return (UTIL_Portal_Color_func)f; // SteamPipe (7197370) - almost sure to break in a later update! // TODO(compat): this has indeed been broken for ages. static const uchar y[] = HEXBYTES(55, 8B, EC, 8B, 45, 0C, 83, E8, 00, 74, 24, 48, 74, 16, 48, 8B, 45, 08, 74, 08, C7, 00, FF, FF); f = mem_offset(base, 0x234C00); - if (!memcmp(f, y, sizeof(y))) return (UTIL_Portal_Color_func)f; + if (!mem_cmp(f, y, sizeof(y))) return (UTIL_Portal_Color_func)f; return 0; } |